Skip to content

Use variadic templates unconditionally#1367

Merged
eddelbuettel merged 15 commits intomasterfrom
feature/variadic_templates
Mar 21, 2025
Merged

Use variadic templates unconditionally#1367
eddelbuettel merged 15 commits intomasterfrom
feature/variadic_templates

Conversation

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Mar 19, 2025

As described in #1366 and building on PR #1364, we can simplify the code by no longer switching based on definition of HAS_VARIADIC_TEMPLATE: only the positive case will be considered given the baseline of C++11.

So this PR removed this file by file, testing each commit locally in CI and arrived at removing the definition. A reverse dependency check is now running as well.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@eddelbuettel
Use variadic templates unconditionally in module/class.h
511f3be 
Remove four generated files
@eddelbuettel
Use variadic templates unconditionally in grow.h
ec2870b 
Remove one generated file
@eddelbuettel
Use variadic templates unconditionally in DottedPair.h
7654d5e 
Remove one generated file
@eddelbuettel
Use variadic templates unconditionally in Vector.h
8235db9 
Remove one generated file
@eddelbuettel
Use variadic templates unconditionally in Function.h
2c13121 
Remove one generated file
@eddelbuettel
Use variadic templates unconditionally in call.h
bf2ede8 
and also in InternalFunctionWithStdFunction.h

Remove one generated file
@eddelbuettel
Use variadic templates unconditionally in Module.h
2b3a93c 
Remove nine generated files
@eddelbuettel
Use variadic templates unconditionally in traits/index_sequece.h
ddf229b 
and traits/named_object.h
@eddelbuettel
Use variadic templates unconditionally in Language.h
e963afa 
Remove one generated file
@eddelbuettel
Use variadic templates unconditionally in DataFrame.h
09b827f 
Remove one generated file
@eddelbuettel
Use variadic templates unconditionally in Pairlist.h
a448967 
Remove one generated file
@eddelbuettel
Use variadic templates unconditionally in InternalFunction.h
b4f9925 
Remove one generated file
@eddelbuettel
No longer define HAS_VARIADIC_TEMPLATES
e28121b
@eddelbuettel
Roll micro release and date
fcdbef1
@eddelbuettel
Copy link
Member Author

eddelbuettel commented Mar 19, 2025

Don't get to do that every day 😆

image

@kevinushey
Copy link
Contributor

kevinushey commented Mar 19, 2025

Don't get to do that every day 😆

image

It's beautiful!

@eddelbuettel
Copy link
Member Author

eddelbuettel commented Mar 19, 2025

I was a little surprised it amounted to so little in the tar.gz:

edd@rob:~/git/rcpp(feature/variadic_templates)$ ls -tltr Rcpp_1.0.14.[78].tar.gz
-rw-r--r-- 1 edd edd 2972038 Mar 16 09:51 Rcpp_1.0.14.7.tar.gz
-rw-r--r-- 1 edd edd 2889287 Mar 18 20:37 Rcpp_1.0.14.8.tar.gz
edd@rob:~/git/rcpp(feature/variadic_templates)$

kevinushey
kevinushey approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel
Copy link
Member Author

eddelbuettel commented Mar 19, 2025

Been burned before so I will probably await the reverse-depends. Maybe just maybe somone relied on the define. Otherwise this is pretty easy (if volumunious): no new code, only removal of code we no longer compiled in. Seemingly no fat-fingered typo ... 🤞

Enchufa2
Enchufa2 approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

eddelbuettel added a commit to RcppCore/rcpp-logs that referenced this pull request Mar 21, 2025
@eddelbuettel
Rcpp 1.0.14.7 with PR 1367
7f03e58 
RcppCore/Rcpp#1367
@eddelbuettel eddelbuettel merged commit 926b8b8 into master Mar 21, 2025
20 checks passed
@eddelbuettel eddelbuettel deleted the feature/variadic_templates branch March 21, 2025 12:34
This was referenced Mar 21, 2025
Closed
Closed
Merged
eddelbuettel added a commit to RcppCore/rcpp-logs that referenced this pull request Mar 24, 2025
@eddelbuettel
Rcpp 1.0.14.9 with PR 1369
d72ac64 
RcppCore/Rcpp#1367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinushey kevinushey kevinushey approved these changes

@Enchufa2 Enchufa2 Enchufa2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eddelbuettel @kevinushey @Enchufa2